fix(scroll): hide when scroll-to-top is clicked (@AzureNightlock)#7999
Open
AzureNightlock wants to merge 2 commits into
Open
fix(scroll): hide when scroll-to-top is clicked (@AzureNightlock)#7999AzureNightlock wants to merge 2 commits into
AzureNightlock wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ScrollToTop button state handling so it hides while scrolling-to-top is in progress (to avoid re-showing mid-scroll).
Changes:
- Add
scrollingsignal to gatehandleScrollupdates during programmatic scroll-to-top - Introduce
scrollUp()helper and await completion before restoring normal scroll handling
Comment on lines
+17
to
+24
| const scrollUp = async (): Promise<void> => { | ||
| const scrollEnded = new Promise<void>((resolve) => { | ||
| if (window.scrollY === 0) return resolve(); | ||
| window.addEventListener("scrollend", () => resolve(), { once: true }); | ||
| }); | ||
| window.scrollTo({ top: 0, behavior: "smooth" }); | ||
| await scrollEnded; | ||
| }; |
Comment on lines
+48
to
+52
| onClick={async () => { | ||
| setVisible(false); | ||
| window.scrollTo({ | ||
| top: 0, | ||
| behavior: "smooth", | ||
| }); | ||
| setScrolling(true); | ||
| await scrollUp(); | ||
| setScrolling(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR: Fixes the scroll to top button so that when clicked it is hidden
Changes Made:
Checks
Closes #7967